Re: [PATCH 6/6] net: Free skbs from irqs when possible.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-03-17 at 23:27 -0700, Eric W. Biederman wrote:
[...]
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -554,14 +554,21 @@ static void kfree_skbmem(struct sk_buff *skb)
>  
>  static void skb_release_head_state(struct sk_buff *skb)
>  {
> +	WARN_ONCE(in_irq() && !skb_irq_freeable(skb),
> +		  "%s called from irq! sp %d nfct %d frag_list %d %pF dst %lx",
> +		  __func__,
> +		  IS_ENABLED(CONFIG_XFRM) ? !!skb->sp : 0,
> +		  IS_ENABLED(CONFIG_NF_CONNTRACK) ? !!skb->nfct : 0,
[...]

This is a syntax error if CONFIG_XFRM or CONFIG_NF_CONNTRACK is
disabled; you have to use #ifdef's.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
                                                         - Carolyn Scheppner

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]