Re: [RFC PATCH 2/2] netpoll: Don't poll for received packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Cong Wang <xiyou.wangcong@xxxxxxxxx> writes:

> On Tue, Mar 11, 2014 at 1:45 AM, Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
>> -       work = napi->poll(napi, budget);
>> -       trace_napi_poll(napi);
>> +       /* Use a budget of 0 to request the drivers not process
>> +        * their receive queue.  Warn when they do anyway.
>> +        */
>> +       work = napi->poll(napi, 0);
>> +       WARN_ON_ONCE(work != 0);
>>
>
> Adding more printk's in netpoll call path would only bring more
> troubles.

That is why I used WARN_ON_ONCE.  So we are alerted to problems but
because it only prints once service won't be denied if nothing except
that warning cares.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]