On Wed, 2014-03-12 at 22:24 +0100, Francois Romieu wrote: > Eric Dumazet <eric.dumazet@xxxxxxxxx> : > [...] > > Same u64_stats_fetch_begin_bh() problem for this driver to fetch TX > > stats. > > Same problem for any NAPI context Tx completing driver that claims > netpoll support. For instance: > drivers/net/ethernet/emulex/benet > drivers/net/ethernet/intel/i40e > drivers/net/ethernet/intel/igb > drivers/net/ethernet/intel/ixgbe > drivers/net/ethernet/marvell/sky2.c > drivers/net/ethernet/neterion/vxge ? > > Similar problem for the drivers below. They update Tx stats in start_xmit > and use u64_.*_bh: > drivers/net/ethernet/tile/tilepro.c > drivers/net/team/team.c > drivers/net/virtio_net.c > Yep, note that this issue is not caused by Eric patches, we need to take care of this by providing u64_stats_fetch_{begin|retry}_irq() regardless of how skb are freed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html