Re: [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
> This patch adds the MSGDMA soft IP support for the Altera Triple
> Speed Ethernet driver.

[]

> Signed-off-by: Vince Bridgers <vbridgers2013@xxxxxxxxx>
> ---
> V4: - Modify use of dev_* to netdev_* where possible

Hi again Vince.

trivia:

It'd be better to also use the netif_<foo> forms too.

This can be done later in a follow-on patch if desired.

> diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
[]
> +void msgdma_reset(struct altera_tse_private *priv)
> +{
[]
> +	if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
> +	    (netif_msg_drv(priv)))
> +		netdev_warn(priv->dev,
> +			    "TSE Rx mSGDMA resetting bit never cleared!\n");

	if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
		netif_warn(priv, drv, priv->dev,
			   "TSE Rx mSGDMA resetting bit never cleared!\n");

[]

> +	if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
> +	    (netif_msg_drv(priv)))
> +		netdev_warn(priv->dev,
> +			    "TSE Tx mSGDMA resetting bit never cleared!\n");

	if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
		netif_warn(priv, drv, priv->dev,
			   "TSE Tx mSGDMA resetting bit never cleared!\n");

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]