Re: [RFC PATCH 1/2] netpoll: Remove dead netpoll_rx code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-03-11 at 01:44 -0700, Eric W. Biederman wrote:
> The netpoll_rx code only becomes active if the netpoll rx_skb_hook is
> implemented.  There is not a single implementation of the netpoll
> rx_skb_hook in the kernel.
> 
> There are problems with the netpoll packet receive code. Most
> speifically every packet that makes it to netpoll_neigh_reply is
> leaked.
> 
> Given that the netpoll packet receive code is buggy and has not been used
> for a decade let's just remove it.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> ---
>  drivers/net/Kconfig       |    5 -
>  include/linux/netdevice.h |   17 --
>  include/linux/netpoll.h   |   59 ------
>  net/core/dev.c            |   11 +-
>  net/core/netpoll.c        |  471 ---------------------------------------------
>  5 files changed, 1 insertions(+), 562 deletions(-)

I cannot agree more, thanks Eric.

Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]