On Mar 5, 2014, at 11:59 AM, Casey Leedom <leedom@xxxxxxxxxxx> wrote: > > On Mar 5, 2014, at 11:52 AM, Or Gerlitz <or.gerlitz@xxxxxxxxx> wrote: > >> On Wed, Mar 5, 2014 at 9:46 PM, Casey Leedom <leedom@xxxxxxxxxxx> wrote: >> >> are you referring to constants defined in >> drivers/net/ethernet/chelsio/cxgb4/t4_hw.h or other/more headers? > > t4_regs.h. Strangely, when we submitted the driver, the very similar symbolic constant formats in t4_msg.h and t4fw_api.h weren’t targeted; just the ones in t4_regs.h. By the way, please don’t take this as in any way advocating that the symbolic constants in t4_msg.h and t4fw_api.h should also be changed in a way which is incompatible with out out-of-kernel development tree — our lives are hard enough already with the changes symbolic constants in t4_regs.h! :-) Casey-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html