Re: [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar 5, 2014, at 11:52 AM, Or Gerlitz <or.gerlitz@xxxxxxxxx> wrote:

> On Wed, Mar 5, 2014 at 9:46 PM, Casey Leedom <leedom@xxxxxxxxxxx> wrote:
>> On Mar 5, 2014, at 11:39 AM, Or Gerlitz <or.gerlitz@xxxxxxxxx> wrote:
>>> On Wed, Mar 5, 2014 at 9:15 PM, Casey Leedom <leedom@xxxxxxxxxxx> wrote:
>>>> Yes, thanks mightily for your help and advice and sorry for the size of the updates.  Hari has taken on the very difficult task of synchronizing our out-of-kernel development branch with the in-kernel code.  These two code bases have drifted apart quite a bit because of the difficulty of translating our out-of-kernel changes into the in-kernel driver which uses completely different symbolic register constants.
>>> 
>>> Can you explain this in a little bit more details? what's the source
>>> of the need to use two different sets of symbolic register constants?
>> 
>>  When our cxgb4 driver was first submitted for inclusion in kernel.org someone objected to the format of our symbolic register constants and forced us to change them.
> 
> are you referring to constants defined in
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.h or other/more headers?

  t4_regs.h.  Strangely, when we submitted the driver, the very similar symbolic constant formats in t4_msg.h and t4fw_api.h weren’t targeted; just the ones in t4_regs.h.

Casey

> Unfortunately these constants are generated directly from our hardware
> design and we can't change them internally -- it would significantly
> increase development/debugging time with our hardware team if we had
> to constantly help the hardware team member translate back and forth
> between the confusingly similar but different names.  Additionally,
> though I know that this isn't a concern of kernel.org, every other OS
> driver for our adapters use the hardware-derived symbolic register
> constants and our software team internally often work on several
> different OS Drivers as we work out better ways to do various things.
> All of this means that our in-house/out-of-kernel driver uses the
> hardware-derived symbolic constants and every time we need to push a
> change into kernel.org we need to go through a very careful
> translation of the symbolic register constants.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]