Re: [PATCH] netpoll: Don't call driver methods from interrupt context.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: ebiederm@xxxxxxxxxxxx (Eric W. Biederman)
Date: Tue, 04 Mar 2014 16:03:43 -0800

> So I would like some clear guidance.  Will you accept patches to make
> it safe to call the napi poll routines from hard irq context, or should
> we simply defer messages prented with netconsole in hard irq context
> into another context where we can run the napi code?
> 
> If there is not a clear way to fix the problems that crop up we should
> just delete all of the netpoll code altogether, as it seems deadly in
> it's current form.

Clearly to make netconsole most useful we should synchronously emit
log messages.

Because what if the system hangs right after this event, but before
we get back to a "safe" context.

That's one bug that will be a billion times harder to diagnose if
we defer.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]