Re: [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Edward Cree <ecree@xxxxxxxxxxxxxx>
Date: Tue, 4 Mar 2014 20:11:34 +0000

> Faster than memcpy/memset on some architectures.
> 
> Signed-off-by: Edward Cree <ecree@xxxxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/sfc/ef10.c        | 13 +++++--------
>  drivers/net/ethernet/sfc/efx.c         |  4 ++--
>  drivers/net/ethernet/sfc/ethtool.c     | 17 ++++++++---------
>  drivers/net/ethernet/sfc/falcon.c      |  2 +-
>  drivers/net/ethernet/sfc/filter.h      |  2 +-
>  drivers/net/ethernet/sfc/mcdi.c        | 14 ++++++++------
>  drivers/net/ethernet/sfc/mcdi_port.c   |  4 ++--
>  drivers/net/ethernet/sfc/selftest.c    |  6 +++---
>  drivers/net/ethernet/sfc/siena_sriov.c | 13 ++++++-------
>  9 files changed, 36 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index 3b39798..de0c815 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -162,8 +162,8 @@ static int efx_ef10_get_mac_address(struct efx_nic *efx, u8 *mac_address)
>  	if (outlen < MC_CMD_GET_MAC_ADDRESSES_OUT_LEN)
>  		return -EIO;
>  
> -	memcpy(mac_address,
> -	       MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE), ETH_ALEN);
> +	ether_addr_copy(mac_address,
> +	       MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE));

This is not indented correctly, the original code was.

When a function call spans multiple lines, the arguments on the second
and subsequent lines must start at the first column after the openning
parenthesis of the function call.

You must use the appropriate number of TAB and space characters necessary
to achieve this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]