On Tue, 2014-03-04 at 18:11 +0530, Hariprasad Shenai wrote: > From: Kumar Sanghvi <kumaras@xxxxxxxxxxx> > > Based on original work by Casey Leedom <leedom@xxxxxxxxxxx> trivial comments: > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c > @@ -2031,21 +2041,65 @@ static void sge_rx_timer_cb(unsigned long data) [] > + if (idma_same_state_cnt[i] < s->idma_1s_thresh) { > + if (s->idma_stalled[i] >= SGE_IDMA_WARN_THRESH) > + CH_WARN(adap, "SGE idma%d, queue%u,resumed after %d sec", Missing terminating '\n', probably better as: CH_WARN(adap, "SGE idma%d, queue%u, resumed after %d sec\n", > + CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs" > + " (debug0=%#x, debug11=%#x)\n", Probably better with the format coalesced: CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n", -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html