Re: [PATCHv3 net-next 29/31] iw_cxgb4: minor fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03/04/2014 03:41 PM, Hariprasad Shenai wrote:

From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>

Added some missing debug stats.

Use uninitialized_var().

Initialize reserved fields in a FW work request.

   You should really split this patch.

Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
---
  drivers/infiniband/hw/cxgb4/cq.c       | 2 +-
  drivers/infiniband/hw/cxgb4/mem.c      | 6 +++++-
  drivers/infiniband/hw/cxgb4/qp.c       | 2 ++
  drivers/infiniband/hw/cxgb4/resource.c | 8 ++++++--
  4 files changed, 14 insertions(+), 4 deletions(-)
[...]

diff --git a/drivers/infiniband/hw/cxgb4/resource.c b/drivers/infiniband/hw/cxgb4/resource.c
index cdef4d7..16982f2 100644
--- a/drivers/infiniband/hw/cxgb4/resource.c
+++ b/drivers/infiniband/hw/cxgb4/resource.c
[...]
@@ -323,7 +327,7 @@ u32 c4iw_rqtpool_alloc(struct c4iw_rdev *rdev, int size)
  	PDBG("%s addr 0x%x size %d\n", __func__, (u32)addr, size << 6);
  	if (!addr)
  		printk_ratelimited(KERN_WARNING MOD "%s: Out of RQT memory\n",
-		       pci_name(rdev->lldi.pdev));
+			pci_name(rdev->lldi.pdev));

This is not indented enough anyway, the like should start under KERN_WARNING, according to the networking coding style. Moreover, this change is now undocumented in the changelog.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]