Hello. On 12/04/2013 06:44 PM, Sebastian Hesselbarth wrote:
Since phy_attach ensures PHYs are resumed, we can now suspend all PHYs that have no attached netdev after initcalls.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> --- Changelog: RFCv1->RFCv2: - only check for phydev->attached_dev and let phy_suspend decide on performing suspend or not (Suggested by Florian)
@Florian: You suggested to 'make sure that the MDIO bus suspend policy was set to "auto"'. I wasn't able to find any clue how to check that, so I ignored that for now.
Cc: David Miller <davem@xxxxxxxxxxxxx> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> Cc: Mugunthan V N <mugunthanvnm@xxxxxx> Cc: netdev@xxxxxxxxxxxxxxx Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx --- drivers/net/phy/mdio_bus.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 5617876..f533d17 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -320,6 +320,31 @@ static int mdio_bus_match(struct device *dev, struct device_driver *drv) (phydev->phy_id & phydrv->phy_id_mask)); } +static int mdio_bus_suspend_unused(struct device *busdev, void *data) +{ + struct mii_bus *bus = to_mii_bus(busdev); + struct phy_device *phydev; + int i; + + for (i = 0; i < PHY_MAX_ADDR; i++) { + if (!bus->phy_map[i]) + continue; + + phydev = to_phy_device(&bus->phy_map[i]->dev);
Why so complex? 'bus->phy_map[i]' already gives you 'phydev'.
+ if (!phydev->attached_dev) + phy_suspend(phydev); + } + + return 0; +}
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html