On Fri, 2013-11-29 at 15:47 -0500, David Miller wrote: > From: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> > Date: Wed, 27 Nov 2013 23:35:55 -0800 > > > From: Carolyn Wyborny <carolyn.wyborny@xxxxxxxxx> > > > > This patch adds a call to dev_close if the queue reinit fails in order > > to make clearer to the user that the device is down. > > > > Signed-off-by: Carolyn Wyborny <carolyn.wyborny@xxxxxxxxx> > > Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> > > This is a very bad approach to this problem. > > Users absolutely do not expect their entire interface to go down > simply because an ethtool request cannot be satisfied. This is > extremely poor quality of implementation. > > And in this specific case it absolutely is not necessary. > > The only thing that can fail is the queue allocation, so make a > function which can preserve the previous configuration if the queue > allocation fails. How about "igb_reinit_interrupt_scheme". > > Don't free the q vectors until the very last moment, when you know > that the allocation of the new q vectors has succeeded. > > I'm not applying this patch, it needs to be reimplemented more > sanely, using the above suggestions or similar. > > Thanks. Thanks for the feedback Dave, I will drop this patch from the series so that Carolyn can re-work the solution.
Attachment:
signature.asc
Description: This is a digitally signed message part