Re: [PATCH v2 net] af_packet: block BH in prb_shutdown_retire_blk_timer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Daniel Borkmann <dborkman@xxxxxxxxxx>
Date: Fri, 29 Nov 2013 10:19:29 +0100

> On 11/29/2013 09:53 AM, Veaceslav Falico wrote:
>> Currently we're using plain spin_lock() in
>> prb_shutdown_retire_blk_timer(),
>> however the timer might fire right in the middle and thus try to
>> re-aquire
>> the same spinlock, leaving us in a endless loop.
>>
>> To fix that, use the spin_lock_bh() to block it.
>>
>> CC: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> CC: Daniel Borkmann <dborkman@xxxxxxxxxx>
>> CC: Willem de Bruijn <willemb@xxxxxxxxxx>
>> CC: Phil Sutter <phil@xxxxxx>
>> CC: Eric Dumazet <edumazet@xxxxxxxxxx>
>> Reported-by: Jan Stancek <jstancek@xxxxxxxxxx>
>> Tested-by: Jan Stancek <jstancek@xxxxxxxxxx>
>> Signed-off-by: Veaceslav Falico <vfalico@xxxxxxxxxx>
> 
> Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer
> implementation.")
> Acked-by: Daniel Borkmann <dborkman@xxxxxxxxxx>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]