David Chang [mailto:dchang@xxxxxxxx] > Sent: Thursday, November 28, 2013 2:23 PM > To: Hayeswang > Cc: netdev@xxxxxxxxxxxxxxx; 'David S. Miller'; 'Francois > Romieu'; jlee@xxxxxxxx; nic_swsd > Subject: Re: [PATCH net] r8169: check ALDPS bit and disable > it if enabledforthe 8168g > > On Thu, Nov 28, 2013 at 01:28:08PM +0800, hayeswang wrote: > > David Chang [mailto:dchang@xxxxxxxx] > > > Sent: Thursday, November 28, 2013 12:29 PM > > > To: Hayeswang > > > Cc: netdev@xxxxxxxxxxxxxxx; 'David S. Miller'; 'Francois > > > Romieu'; jlee@xxxxxxxx; nic_swsd > > > Subject: Re: [PATCH net] r8169: check ALDPS bit and disable > > > it if enabled forthe 8168g > > [...] > > > > You have to delay at least 10 ms after disable it. > > > > This makes sure the hw completes the action. > > > > > > > > > > Thanks for your comment. > > > I'd add a delay time and send the v2 version. > > > > Excuse me. Our engineers have different opinions about the delay. > > I would comfirm it first. > > > OK! I'd wait until the final result, thanks! The delay is unnecessary. Thanks. Acked-by: Hayes Wang <hayeswang@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html