Re: Bug: alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-08-06 at 03:43 -0700, Eric Dumazet wrote:

> > $ ethtool -S eth0
> > no stats available
> 
> It seems alx driver does not support stats.
> 
> (No ndo_get_stats() and no changes on netdev->stats embedded stats)
> 
> 
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c provides
> atl1c_get_stats() gathering hardware counters
> 
> CC Johannes Berg, let see if he has plan to add them on alx

I don't. There are some stats in the original code at
https://github.com/erikarn/alx, but I removed them because I didn't
really understand what was going on and don't really care much for the
stats in the system I'm using this device on - and based on the driver
I'm not sure I'd use the chip for 'serious' work anyway :)

FWIW, it had ndo_get_stats() but was updating the netdev->stats from
that handler and then returning them, which seemed a bit questionable.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]