Re: IP fragmentation broken in 3.6-rc ?

[Julian Anastasov <ja@xxxxxx>]

	Hello,

On Tue, 21 Aug 2012, Eric Dumazet wrote:

> Following patch should help :
> 
> diff --git a/include/net/dst.h b/include/net/dst.h
> index 621e351..a04aa37 100644
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -435,7 +435,7 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout)
>  	if (expires == 0)
>  		expires = 1;
>  

	In theory, restart of PMTUD should not lead to
fatal problems, we will get new MTUs. But with such
change should be better, not much, because all MTU
events will come at same time, later timer will expire
and we will get again events from routers. The gain
will be an increased period (with milliseconds to seconds)
between PMTUD restarts. Compared to the 600-second timer,
this should be gain below 1% in reduced traffic for PMTUD.
Before now we started timer from first router, now we
will start/update timer period after event from last router.

	But ipv4_link_failure and ip6_link_failure want to stop
this timer by setting it to NOW (0). May be we have to add
also a !timeout check here or to leave the code as before?

> -	if (dst->expires == 0 || time_before(expires, dst->expires))
> +	if (dst->expires == 0 || time_after(expires, dst->expires))
>  		dst->expires = expires;
>  }

	The original problem should be somewhere else, I think.

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html