Re: [net PATCH v1 2/2] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly

[John Fastabend <john.r.fastabend@xxxxxxxxx>]

On 8/13/2012 7:31 PM, Al Viro wrote:
> On Mon, Aug 13, 2012 at 06:39:45PM -0700, John Fastabend wrote:
> >   		/* Bump the usage count and install the file. */
> >   		get_file(fp[i]);
> >   		fd_install(new_fd, fp[i]);
> > +		sock = sock_from_file(fp[i], &err);
> > +		if (sock)
> > +			sock->sk->sk_cgrp_prioidx = prioidx;
>
> Better to do that before fd_install() exposes the sucker; it's not
> a serious issue, but it's more obviously correct that way.

Right. Moved it in v2.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html