Re: [net] ixgbe: Do not pad FCoE frames as this can cause issues with FCoE DDP

[Ben Hutchings <ben@xxxxxxxxxxxxxxx>]

On Tue, 2012-06-26 at 08:48 -0700, Alexander Duyck wrote:
> On 06/26/2012 07:09 AM, Ben Hutchings wrote:
> > On Tue, 2012-06-26 at 00:53 -0700, Jeff Kirsher wrote:
> >> On Tue, 2012-06-26 at 00:50 -0700, David Miller wrote:
> >>> Sorry, quotes don't work either, what you did is still a SMTP syntax error,
> >>> here's what is in the bounce I get back:
> >>>
> >>> 	<stable@xxxxxxxxxxxxxxx> "[3.4]",
> >>> 	Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> >>> Illegal-Object:	Syntax error in Cc: address found on vger.kernel.org:
> >>> 	Cc:	<stable@xxxxxxxxxxxxxxx>"[3.4]"
> >>> 						^-missing end of address
> >> Grrr...
> >>
> >> I will re-send without the "[3.4]", Greg will just have to deal with it.
> > It's certainly not necessary to put anything like that in the real Cc
> > header. Many people put something like
> > 'Cc: <stable@xxxxxxxxxxxxxxx> # 3.4' in the body; I don't know if that
> > is more like likely to result in the version being stripped when
> > generating mail recipients.
> >
> > Ben.
> >
> Couldn't 3.4 have been put in place of the recipient's name?  So you do
> something like this:
> Cc: 3.4 <stable@xxxxxxxxxxxxxxx>

Aside from the fact that recipient names with dots must be quoted in the
real header, it's relatively uncommon to use this format and the import
script I use for 3.2.y wouldn't notice it.  (So I'd have to go back and
look at the original commit header to work out that it wasn't relevant.)
I don't know whether Greg's script extracts the recipient name.

Ben.

-- 
Ben Hutchings
Lowery's Law:
             If it jams, force it. If it breaks, it needed replacing anyway.

Attachment: signature.asc
Description: This is a digitally signed message part