Re: PPPoE performance regression

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On Sun, 2012-06-10 at 09:32 +0100, David Woodhouse wrote:
> I was looking to see if we could (ab)use the skb->destructor somehow so
> that we get *notified* when the packet is actually sent (or dropped),
> and then that would allow us to manage the queue 'downstream' of PPP
> more sanely. But I haven't really got very far with that yet.

This doesn't look *so* evil... if the basic concept of using
skb_orphan() and then setting our own destructor is OK, then I'll work
out the rest of the details and do it for l2tp too.

If the end-goal is to do BQL for PPP and honour the netdev queue limits,
perhaps the best option is to add a 'done sending skb' callback to the
generic ppp code and let it manage the queues (and the BQL callbacks)
*there*.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

<<attachment: smime.p7s>>