Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug

[Joe Perches <joe@xxxxxxxxxxx>]

On Tue, 2012-05-15 at 18:35 -0700, Stephen Hemminger wrote:
> On Tue, 15 May 2012 17:11:54 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> 
> > Use the current debugging style and enable dynamic_debug.
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> 
> This changes the action of the system. By default:
>   printk(KERN_DEBUG "foo\n");
> is enabled all the time and prints to log with debug level.
> 
> But your version
>   pr_debug("foo\n");
> defaults to being dropped until the system is built with dynamic
> debug, and that particular debug instance is enabled.
> 
> Since these are all useful, but low priority messages, not I
> don't think disabling them by default is such a great idea now.

Just had that discussion with David Miller.

http://marc.info/?l=linux-sctp&m=133710673230503&w=2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html