On Mon, 30 Apr 2012 10:39:08 +0200 Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx> wrote: > My brctl showstp br0 always shows a 0 port id: > eth2 (1) > port id 0 state disabled > designated root 8000.00069c00b2fb path cost 100 > > because port id is printed as a hex number in sys fs. Change the > two hex occurrences(port no and port id) to decimal, just like all > the other numbers in this area. > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx> > --- > net/bridge/br_sysfs_if.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c > index fd5799c..9c4c2eb 100644 > --- a/net/bridge/br_sysfs_if.c > +++ b/net/bridge/br_sysfs_if.c > @@ -86,13 +86,13 @@ static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL); > > static ssize_t show_port_id(struct net_bridge_port *p, char *buf) > { > - return sprintf(buf, "0x%x\n", p->port_id); > + return sprintf(buf, "%d\n", p->port_id); > } > static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL); > > static ssize_t show_port_no(struct net_bridge_port *p, char *buf) > { > - return sprintf(buf, "0x%x\n", p->port_no); > + return sprintf(buf, "%d\n", p->port_no); > } > > static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL); No. This would be a visible change to applications. The bridge utilities should be fixed instead. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html