RE: [PATCH net-next 2/5] be2net: Fix to allow setting of debug levels in the firmware.

[<Somnath.Kotur@xxxxxxxxxx>]

Ben,
 Could you pls respond to my replies inline.

Thanks
Somnath
       

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Somnath.Kotur@xxxxxxxxxx
> Sent: Friday, April 27, 2012 12:16 PM
> To: bhutchings@xxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH net-next 2/5] be2net: Fix to allow setting of debug levels
> in the firmware.
> 
> > > This operation is intended for controlling logging by the driver,
> > > and the flags
> > are defined in <linux/netdevice.h>.  (Not exported to userland yet,
> > but ethtool knows their names.)
> >
> > If your firmware supports some kind of logging then it may be
> > reasonable to have this control both driver and firmware, but not *just*
> the firmware.
> Thanks for your comments Ben.
> 
> Currently the driver logs only a very few critical errors/warnings; so we felt it
> might be an overkill to define driver log levels.
> On the other hand, the F/W has extensive logging and tracing facility and the
> ethtool 'msglevel' option seemed like a reasonable method for controlling
> the logging level.
> 
> >
> > You should also implement the get_msglevel operation at the same time.
> 
> Yes you are correct. We will implement the get_msglevel and re-post the
> patch.
> >
> > Ben.
> >
> 
> Thanks
> Som
> N     r  y   b X  ǧv ^ )޺{.n +   z ^ )   w*jg        ݢj/   z ޖ  2 ޙ   & )ߡ a     G   h  j:+v
> w ٥
��.n��������+%������w��{.n����z����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f