Re: [PATCH net-next] net: cleanups in sock_setsockopt()

[David Miller <davem@xxxxxxxxxxxxx>]

From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Fri, 27 Apr 2012 07:41:59 +0200

> From: Eric Dumazet <edumazet@xxxxxxxxxx>
> 
> Use min()/max() macros, reformat two comments, use !!test_bit() to
> match !!sock_flag()
> 
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Introduces warnings:

net/core/sock.c: In function ʽsock_setsockoptʼ:
net/core/sock.c:584:9: warning: comparison of distinct pointer types lacks a cast [enabled by default]
net/core/sock.c:605:9: warning: comparison of distinct pointer types lacks a cast [enabled by default]
net/core/sock.c:623:19: warning: comparison of distinct pointer types lacks a cast [enabled by default]

and that makes sense since int is signed and __u32 is not.

Your compiler didn't spit that out too?
?τθΊ{.nΗ+?·???­?+%?Λ?±ιέΆ??w?Ί{.nΗ+?·§zΧ^Ώψ§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨ώψ―ω?w?ώ?ΰ2?ή?¨θ­Ϊ&ʼ)ίʽ«aΆΪ??ϋΰzΏδzΉή?ϊ+?ω???έʼj??wθώf