Re: 3.3.0, 3.4-rc1 reproducible tun Oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



17.04.2012 06:08, Simon Kirby пишет:
On Thu, Apr 05, 2012 at 04:41:04AM +0200, Eric Dumazet wrote:

Hmm, is it happening if you remove the nvidia module ?

If yes, please try to add slub_debug=FZPU

Finally got annoyed enough at this to bisect it. It doesn't happen every
time and I got a bit confused, but I finally tracked it down to:

1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d is the first bad commit
commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d
Author: Stanislav Kinsbursky<skinsbursky@xxxxxxxxxxxxx>
Date:   Mon Mar 12 02:59:41 2012 +0000

     tun: don't hold network namespace by tun sockets

     v3: added previously removed sock_put() to the tun_release() callback, because
     sk_release_kernel() doesn't drop the socket reference.

     v2: sk_release_kernel() used for socket release. Dummy tun_release() is
     required for sk_release_kernel() --->  sock_release() --->  sock->ops->release()
     call.

     TUN was designed to destroy it's socket on network namesapce shutdown. But this
     will never happen for persistent device, because it's socket holds network
     namespace.
     This patch removes of holding network namespace by TUN socket and replaces it
     by creating socket in init_net and then changing it's net it to desired one. On
     shutdown socket is moved back to init_net prior to final put.

     Signed-off-by: Stanislav Kinsbursky<skinsbursky@xxxxxxxxxxxxx>
     Signed-off-by: David S. Miller<davem@xxxxxxxxxxxxx>

...With this reverted on top of 3.4-rc3, I no longer see crashes when I
keep making and breaking the SSH tunnel while running "vmstat 1" in an
SSH session over a socket that is running through that tunnel.

Simon-

Hi, Simon.
Could you please try to apply the patch below on top of your the tree (with 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d applied) and check does it fix the problem:

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index bb8c72c..1fc4622 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1540,13 +1540,10 @@ static int tun_chr_close(struct inode *inode, struct file *file)
 			if (dev->reg_state == NETREG_REGISTERED)
 				unregister_netdevice(dev);
 			rtnl_unlock();
-		}
+		} else
+			sock_put(tun->socket.sk);
 	}

-	tun = tfile->tun;
-	if (tun)
-		sock_put(tun->socket.sk);
-
 	put_net(tfile->net);
 	kfree(tfile);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]