Re: [PATCH][trivial] ipv4: fix checkpatch errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

From: dbaluta@xxxxxxxxxxx
Date: Sun, 15 Apr 2012 14:34:41 +0300

> From: Daniel Baluta <dbaluta@xxxxxxxxxxx>
> 
> Fix checkpatch errors of the following type:
> 	* ERROR: "foo * bar" should be "foo *bar"
> 	* ERROR: "(foo*)" should be "(foo *)"
> 
> Signed-off-by: Daniel Baluta <dbaluta@xxxxxxxxxxx>

Applied, but:

> @@ -216,7 +216,7 @@ static struct rtnl_link_stats64 *ipgre_get_stats64(struct net_device *dev,
>  
>  /* Given src, dst and key, find appropriate for input tunnel. */
>  
> -static struct ip_tunnel * ipgre_tunnel_lookup(struct net_device *dev,
> +static struct ip_tunnel *ipgre_tunnel_lookup(struct net_device *dev,
>  					      __be32 remote, __be32 local,
>  					      __be32 key, __be16 gre_proto)
>  {

I had to reindent these function arguments on the lines after the one
you modified so that they continue to line up properly with the column
of the openning parenthesis on the previous line.

Do not blindly make checkpatch fixes without taking into consideration
the indentation modifications necessary in the context around your
change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux