Re: [PATCH v2 4/4] ath9k: Support ethtool getstats api.

[Ben Greear <greearb@xxxxxxxxxxxxxxx>]

On 03/16/2012 01:57 PM, Ben Hutchings wrote:
> On Fri, 2012-03-16 at 20:53 +0000, Ben Hutchings wrote:
> > On Fri, 2012-03-16 at 12:59 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> > > From: Ben Greear<greearb@xxxxxxxxxxxxxxx>
> > >
> > > This returns many of the values that formerly could
> > > only be obtained from debugfs.  This should be an
> > > improvement when trying to access these counters
> > > programatically.  Currently this support is only
> > > enabled when DEBUGFS is enabled because otherwise
> > > these stats are not accumulated.
> > [...]
> >
> > Given that ethtool (unlike debugfs) is itself an unconditional feature,
> > why not make this unconditional?  Is it expensive to accumulate the
> > stats?
> >
> > Please at least fix the name.
>                           ^ config option

The ath9k stats are currently only gathered when debugfs is enabled.

I could do some patches in the future to allow stats to always
be gathered regardless of debugfs being enabled, but since
ath9k is used on small form factor systems, there may be some
resistance to enabling that all the time.

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html