Re: [net 2/2] net: fix a bug of dropping FCoE frames when disabling tx ip checksum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Zou, Yi" <yi.zou@xxxxxxxxx>
Date: Wed, 14 Mar 2012 22:04:06 +0000

>> 
>> From: "Zou, Yi" <yi.zou@xxxxxxxxx>
>> Date: Wed, 14 Mar 2012 20:48:03 +0000
>> 
>> > CHECKSUM_UNNECESSARY sounds good to me, if it's ok to be used on the tx
>> path 
>> > as well, I think so but I am not 100% sure, it'd resolve this for fcoe
>> and sctp
>> > like, downside is it's a bigger change that requires corresponding
>> changes in
>> > these protocol driver stacks as well.
>> 
>> This is definitely the way this bug should be fixed, CHECKSUM_PARTIAL should
>> never be set for packets outside of the domain that value was designed for.
> 
> Cool, then please drop this patch and I will fix this by changing the fcoe 
> protocol stack driver to use CHECKSUM_UNNECESSARY instead.

I've dropped both patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]