Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC
On 03/13/2012 09:16 PM, Dave Taht wrote:
On Tue, Mar 13, 2012 at 10:21 AM, Amir Vadai<amirv@xxxxxxxxxxxx> wrote:From: Amir Vadai<amirv@xxxxxxxxxxxxxx> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit To set, enter a space separated list of values in units of 100Mbps. For example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue: echo 50 100 100 100 100 100 100 100 100> /sys/class/net/eth2/qos/ratelimitAt least in my world, rates go down as low as 128k. If this 'qos' sys value is intended to be a generic mechanism to be used instead of (say) htb, for more than one type of ethernet device.... I would argue that the units need to be specified. Similarly what else is intended to live below the 'qos' subdir?
This sys value is specific to our driver, and will be shown only on mlx4_en netdev's.
We're open to suggestions to make it a generic sysfs entry. If it will really be generic, we will sure have well known units (for example KB) and we'll do the translation in our driver.
Thanks, Amir -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Kernel Discussion] [Ethernet Bridging] [Linux Wireless Networking] [Linux Bluetooth Networking] [Linux Networking Users] [VLAN] [Git] [IETF Annouce] [Linux Assembly] [Security] [Bugtraq] [Photo] [Singles Social Networking] [Yosemite Information] [MIPS Linux] [ARM Linux Kernel] [ARM Linux] [Linux Virtualization] [Linux Security] [Linux IDE] [Linux RAID] [Linux SCSI] [Free Dating]