RE: [PATCH 3/4] batman-adv: Use {} braces consistent on the arms of a statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 
> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
> index 01b66d4..7f8e158 100644
> --- a/net/batman-adv/routing.c
> +++ b/net/batman-adv/routing.c
> @@ -237,8 +237,9 @@ int window_protected(struct bat_priv 
> *bat_priv, int32_t seq_num_diff,
>  				"old packet received, start
protection\n");
>  
>  			return 0;
> -		} else
> +		} else {
>  			return 1;
> +		}
>  	}
>  	return 0;
>  }

Doesn't this one fail on the "don't use 'else' after return/break" ?
Also look like it would read better if the condition (not quoted)
were inverted and the 'return 1' put first.

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux