Re: [PATCH] m68k/atari: EtherNEC - rewrite to use mainstream ne.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Paul Gortmaker wrote:
<asm/atariints.h> exists on m68k only, and is not included by any header in
arch/m68k/include/.

This kind of arch specific stuff still shouldn't need to
bubble right up to the driver level  I'd think a driver
should be able to include <asm/irq.h> and have whatever
arch specific goo like this be present.

So maybe this kind of magic should be in arch/m68k/include/asm/irq*
instead of here?
I've double checked - that hunk should not actually have been in the patch at all. My bad ... With all arch-specific interrupt tweaks (aside from the interrupt flags) now removed from the driver, the definition wasn't actually used any longer in the main driver file.

The non-standard interrupt flag will still be required for those users that decide to wire up the card interrupt line to, for example, the modem serial port's ring input.
And on re-reading the comments in the other part of the patch, i.e.
"...emulates the card interrupt via a timer"  --perhaps the driver
should be just fixed to support generic netpoll, instead of adding
an arch specific thing that amounts to netpoll.  Then anyone can
attempt to limp along and use one of these ancient relics w/o IRQ.
I had in fact implemented that as a fallback option earlier, and it turned out to be quite a bit slower that way. If that's the preferred option, I'll add netpoll to the 8390 driver and resubmit.

Thanks,

 Michael

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux