Re: [PATCH 1/2] bridge: Adjust min age inc for HZ > 256

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, 1 Mar 2012 19:12:18 +0100
Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx> wrote:

> min age increment needs to round up its min age tick for all
> HZ values to guarantee message age is increasing.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
> ---
> 
> The bridge list seems very slow so try netdev instead.
> 
>  net/bridge/br_stp.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index a04eeb6..9a8aebd 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -17,9 +17,9 @@
>  #include "br_private_stp.h"
>  
>  /* since time values in bpdu are in jiffies and then scaled (1/256)
> - * before sending, make sure that is at least one.
> + * before sending, make sure that is at least one STP tick.
>   */
> -#define MESSAGE_AGE_INCR	((HZ < 256) ? 1 : (HZ/256))
> +#define MESSAGE_AGE_INCR	((HZ / 256) + 1)
>  
>  static const char *const br_port_state_names[] = {
>  	[BR_STATE_DISABLED] = "disabled",

I don't understand why this is required.
  HZ = 100 then incr = 1
  HZ = 1000 then incr = 3 (your patch would make it for 4).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux