Re: pull request: bluetooth-next 2012-03-01

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Thu, 01 Mar 2012 22:23:16 -0500 (EST)

> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Thu, 01 Mar 2012 22:16:43 -0500 (EST)
> 
>> This was only three commits into your tree, therefore I'm not very
>> optimistic to be honest with you.
> 
> In the very next commit, 3175405b906a85ed2bad21e09c444266e4a05a8e we end
> up with:

And then 2 commits later in ff9ef5787046c3fd20cf9f7ca1cd70260c1eedb9:

+	if (hdev->discovery.state != DISCOVERY_STOPPED) {
+		err = cmd_status(sk, index, MGMT_OP_START_DISCOVERY,
+						MGMT_STATUS_BUSY);
+		goto failed;
+	}

it must be isntead:

		err = cmd_status(sk, index, MGMT_OP_START_DISCOVERY,
				 MGMT_STATUS_BUSY);

And that's pretty much as far as I'm willing to go.

You know what really pisses me off?  This is the one issue I made a huge
stink about last week, arguments to function calls and prototypes lining
up properl.  And it's in ever 2nd or 3rd commit in this pull request.

This means you really didn't check or you really don't care.

Come back when you've audited this whole thing properly and honestly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]