Re: [PATCHv2 net-next 1/2] mdio: Export mdio.h to userland

[David Miller <davem@xxxxxxxxxxxxx>]

From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
Date: Thu, 1 Mar 2012 00:23:27 +0000

> The ID packing definitions are needed by userland and the register
> definitions may also be useful there.
> 
> Do not export mdio_phy_id_{is_c45,prtad,devad}() as the use of bool is
> problematic and it's not that useful to export only a subset of these.
> 
> Do not export MDIO_SUPPORTS_{C22,C45} directly; these flags are only
> exposed to userland through struct ethtool_cmd so they should be
> defined alongside that with appropriate names.
> 
> Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>

Applied, although I had to fixup trailing whitespace:

> +#ifdef __KERNEL__ 

here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html