Re: [PATCH 0/8] validate MAC address before call .ndo_set_mac_address |
|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 0/8] validate MAC address before call .ndo_set_mac_address
- From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
- Date: Wed, 29 Feb 2012 15:58:59 +0000
- Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Eilon Greenstein <eilong@xxxxxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Danny Kukawka <dkukawka@xxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Eric Dumazet <eric.dumazet@xxxxxxxxx>, Florian Fainelli <florian@xxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Javier Martinez Canillas <martinez.javier@xxxxxxxxx>, Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, Jiri Pirko <jpirko@xxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, John Crispin <blogic@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>, Michał Mirosław <mirq-linux@xxxxxxxxxxxx>, Neil Horman <nhorman@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxxxx>
- In-reply-to: <1330530176-24952-1-git-send-email-danny.kukawka@bisect.de>
- Organization: Solarflare Communications
On Wed, 2012-02-29 at 16:42 +0100, Danny Kukawka wrote:
> Validate the given MAC address directly in dev_set_mac_address()
> if a .ndo_validate_addr function is available before calling
> the .ndo_set_mac_address function.
>
> Changed .ndo_validate_addr to take a second parameter containing
> a sockaddr struct to be checked instead of the net_device dev_addr.
> The behaviour of .ndo_validate_addr is now: if the second parameter
> is NULL the net_device->dev_addr gets validate, if != NULL
> the given parameter/sockaddr gets validated instead.
>
> This patch series include adaptations for some drivers which
> use .ndo_set_mac_address functions directly - to prevent double
> checks and to enable validations via .ndo_validate_addr.
[...]
You have to do this as a single patch. The kernel and drivers should
still build at each stage.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Kernel Discussion]
[Ethernet Bridging]
[Linux Wireless Networking]
[Linux Bluetooth Networking]
[Linux Networking Users]
[VLAN]
[Git]
[IETF Annouce]
[Linux Assembly]
[Security]
[Bugtraq]
[Photo]
[Singles Social Networking]
[Yosemite Information]
[MIPS Linux]
[ARM Linux Kernel]
[ARM Linux]
[Linux Virtualization]
[Linux Security]
[Linux IDE]
[Linux RAID]
[Linux SCSI]
[Free Dating]