> -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Tuesday, February 21, 2012 1:50 PM > To: eric.dumazet@xxxxxxxxx > Cc: Rose, Gregory V; netdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] rtnetlink: Fix problem with buffer allocation > > From: Eric Dumazet <eric.dumazet@xxxxxxxxx> > Date: Tue, 21 Feb 2012 22:48:16 +0100 > > > Thats going to hurt some setups (thousand of devices on a server). > > This logic only triggers when the VF attribute is explicitly asked > for. > > > Also why are you using _rcu() variant here, we hold rtnl I presume ? > > Because that's what I told him to use probably :-) Indeed, I think > we can use the non-RCU variant in this spot. In rtnl_fill_ifinfo the code there uses hlist_for_each_entry_rcu() so I think that's why it got carried over here. I can remove it. - Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html