Re: [PATCH] net/fec: infinite spin on sirq-net-tx on real-time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, 2012-02-06 at 12:03 +0100, Hector Palacios wrote:

> >>
> >> @@ -530,6 +531,7 @@ fec_stop(struct net_device *ndev)
> >>   	udelay(10);
> >>   	writel(fep->phy_speed, fep->hwp + FEC_MII_SPEED);
> >>   	writel(FEC_DEFAULT_IMASK, fep->hwp + FEC_IMASK);
> >> +	fep->link = 0;
> >
> >
> > Why not call netif_stop_queue(dev) here ?
> >

> I'm no network driver expert so I'll leave it up to others to comment. I just forward 
> ported a patch I came across in Freescale's BSP which solves the problem in mainline 
> and in RT.

Hector,

Eric's suggestion may also work. Could your revert this patch and add
the netif_stop_queue(dev) there, and see if it fixes the problems in
both mainline and -rt?

Thanks!

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux