Re: [PATCH net-next 6/7] r8169: missing barriers.

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Eric Dumazet <eric.dumazet@xxxxxxxxx> :
[...]
> It would be good changelog explains the rationale, or you add comments
> in the code.

Something like :
----------------8<----------------------------------------------------------
rtl8169_tx_interrupt must see the updated queue status from
rtl8169_start_xmit while rtl8169_start_xmit still has to see the
updated dirty index from rtl8169_tx_interrupt.

The window for the TxPoll hack is widened: it should not make much
difference when the last TxPoll request in a close serie of xmit fails as
long as the Tx napi method runs late enough after the last successful xmit.
------------------------------------------>8--------------------------------

Your comments are welcome.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html