Re: [PATCH] fix ip_gre lockless xmits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Le jeudi 26 janvier 2012 à 15:34 -0500, Willem de Bruijn a écrit :
> Tunnel devices set NETIF_F_LLTX to bypass HARD_TX_LOCK.  Sit and
> ipip set this unconditionally in ops->setup, but gre enables it
> conditionally after parameter passing in ops->newlink. This is
> not called during tunnel setup as below, however, so GRE tunnels are
> still taking the lock.
> modprobe ip_gre
> ip tunnel add test0 mode gre remote dev lo
> ip link set test0 up
> ip addr add dev test0
>  # cat /sys/class/net/test0/features
>  # $DIR/test_tunnel_xmit 10
> ip route add dev test0
> ip tunnel del test0

> Signed-off-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Sure !

When I did the original patch, I used following setup sequence.

ip link add gre34 type gre remote

I was not aware of the "ip tunnel add ..."

Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux