|
|
RE: [PATCH net] mlx4_en: set number of rx rings used by RSS using ethtool |
> > + /* RSS table size must be an order of 2 */
> > + if (rss_rings != (1 << order_base_2(rss_rings)))
> > + return -EINVAL;
>
> This is an obscure way to make this kind of test.
>
> The canonical way is:
>
> if (is_power_of_2(rss_rings))
Which is probably (x & {x-1)) == 0
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
|