Re: [PATCH net] mlx4_en: set number of rx rings used by RSS using ethtool

[David Miller <davem@xxxxxxxxxxxxx>]

From: Yevgeny Petrilin <yevgenyp@xxxxxxxxxxxxxx>
Date: Tue, 17 Jan 2012 18:50:24 +0200

> +	/* RSS table size must be an order of 2 */
> +	if (rss_rings != (1 << order_base_2(rss_rings)))
> +		return -EINVAL;

This is an obscure way to make this kind of test.

The canonical way is:

	if (is_power_of_2(rss_rings))

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html