Re: [PATCH net 2/2] net: WARN if skb_checksum_help() is called on skb requiring segmentation

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>]

On Mon, Jan 16, 2012 at 10:43:38PM +0000, Ben Hutchings wrote:
> skb_checksum_help() has never done anything useful with skbs that
> require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
> them invalid and provokes a later WARNing in skb_gso_segment().
> 
> Passing such an skb to skb_checksum_help() indicates a bug, so we
> should warn about it immediately.  Move the warning from
> skb_gso_segment() into a shared function, and add the calling function
> name, gso_type and gso_size to it.
> 
> Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
> ---
> The price for writing the warning format only once is having to pass in
> the calling function name.  Not sure whether it's a good trade-off.

Do we really need the name since we should get a back trace?

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html