Re: [PATCH] vhost-net: add module alias (v2.1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Fri, Jan 13, 2012 at 05:07, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Stephen Hemminger <shemminger@xxxxxxxxxx>
> Date: Wed, 11 Jan 2012 21:30:38 -0800
>
>> Subject: vhost-net: add module alias (v2.1)
>>
>> By adding some module aliases, programs (or users) won't have to explicitly
>> call modprobe. Vhost-net will always be available if built into the kernel.
>> It does require assigning a permanent minor number for depmod to work.
>>
>> Also:
>>   - use C99 style initialization.
>>   - add missing entry in documentation for loop-control
>>
>> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
>
> ACKs, NACKs?  What is happening here?

In general, static minors are acceptable and very useful to make
on-demand loading of kernel modules working. They should be used only
for single-instance devices though, which usually means: One single
static device name associated with a module.

That looks all fine here, and for what it's worth:
  Acked-By: Kay Sievers <kay.sievers@xxxxxxxx>

Kay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux