Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address

[Neil Horman <nhorman@xxxxxxxxxxxxx>]

On Wed, Jan 04, 2012 at 02:43:18PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@xxxxxxxxxxxxx>
> Date: Wed,  4 Jan 2012 11:47:23 -0500
> 
> > +extern void addrconf_prefix_rcv(struct net_device *dev,
> > +				u8 *opt, int len, void *sllao);
> 
> You're not going to dereference or inspect 'sllao' otherwise you'd
> give it a more appropriate type.  You just care if it was present or
> not.
> 
> So why not just make 'sllao' a "bool" and the argument passed as the
> test "X != NULL"?
> 

Honestly I was just avoiding doing the extra comparison.  I'm happy to pass it
as a test like that though if you think its cleaner.  I'll repost shortly.

Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html