Re: [PATCH] r8169: Enable suspend when device is idle from boot.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Tue, Jan 3, 2012 at 3:30 PM, Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:
> Francois Romieu <romieu@xxxxxxxxxxxxx> :
> [...]
>> The description of the patch implies that the initial power management
>> state is not right. I would be more inclined to set it correctly when
>> the device goes up instead of checking repeatedly for a loss of sync
>> through rtl8169_runtime_idle. Todd, any comment ?
>
> ... which could be as simple as (completely untested) :

That change is just to the code path of open(), which means that for
the power savings to kick in, you have to bring the interface up. The
point of the original patch is to check even if the interface has
never been touched.

Perhaps call check_link_status at the end if init_one instead to
activate pm then?


-Olof
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel Discussion]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux Bluetooth Networking]     [Linux Networking Users]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Photo]     [Singles Social Networking]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux Security]     [Linux IDE]     [Linux RAID]     [Linux SCSI]     [Free Dating]

Add to Google Powered by Linux