Re: [PATCH] r8169: Enable suspend when device is idle from boot.

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Francois Romieu <romieu@xxxxxxxxxxxxx> :
[...]
> The description of the patch implies that the initial power management
> state is not right. I would be more inclined to set it correctly when
> the device goes up instead of checking repeatedly for a loss of sync
> through rtl8169_runtime_idle. Todd, any comment ?

... which could be as simple as (completely untested) :

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index c8f47f1..e9fbd41 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -4309,7 +4309,7 @@ static int rtl8169_open(struct net_device *dev)
 	tp->saved_wolopts = 0;
 	pm_runtime_put_noidle(&pdev->dev);
 
-	rtl8169_check_link_status(dev, tp, ioaddr);
+	__rtl8169_check_link_status(dev, tp, ioaddr, true);
 out:
 	return retval;
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html