RE: [net-next 08/11] e1000e: add Receive Packet Steering (RPS) support

["Allan, Bruce W" <bruce.w.allan@xxxxxxxxx>]

>-----Original Message-----
>From: David Miller [mailto:davem@xxxxxxxxxxxxx]
>Sent: Tuesday, January 03, 2012 12:10 PM
>To: Kirsher, Jeffrey T
>Cc: Allan, Bruce W; netdev@xxxxxxxxxxxxxxx; gospo@xxxxxxxxxx;
>sassmann@xxxxxxxxxx
>Subject: Re: [net-next 08/11] e1000e: add Receive Packet Steering (RPS) support
>
>From: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
>Date: Tue,  3 Jan 2012 11:19:13 -0800
>
>> +		e_err("Enabling both receive checksum offload and receive hashing is
>not possible with jumbo frames.  Disable jumbos or enable only one of the
>receive offload features.\n");
>
>Please split this up into multiple lines like this:
>
>	e_err("..."
>	      "..."
>	      "...");
>
>Thanks.

I was under the impression from recently accepted patches that the preferred
method for log/error message strings was to keep them as a single string
(rather than broken across multiple lines) for easy searching.  Is that not
the case here?

>From ./Documentation/CodingStyle..."never break user-visible strings such as
printk messages, because that breaks the ability to grep for them."

Do you still want this change?

Thanks,
Bruce.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html