Re: [PATCH 1/1] net/fec: add KSZ9021RN phy fixup

[Richard Zhao <richard.zhao@xxxxxxxxxxxxx>]

On Mon, Dec 12, 2011 at 04:42:07PM +0200, Veli-Pekka Peltola wrote:
> On 12/12/2011 03:51 PM, Richard Zhao wrote:
> >On Mon, Dec 12, 2011 at 10:56:48AM -0200, Fabio Estevam wrote:
> >>On Mon, Dec 12, 2011 at 8:09 AM, Richard Zhao<richard.zhao@xxxxxxxxxx>  wrote:
> >>>For imx6q sabrelite board, set phy RGMII pad skew.
> >>>
> >>>Signed-off-by: Richard Zhao<richard.zhao@xxxxxxxxxx>
> >>>---
> >>>  drivers/net/ethernet/freescale/fec.c |   19 +++++++++++++++++++
> >>>  1 files changed, 19 insertions(+), 0 deletions(-)
> >>>
> >>>diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> >>>index 112af9b..d3b4463 100644
> >>>--- a/drivers/net/ethernet/freescale/fec.c
> >>>+++ b/drivers/net/ethernet/freescale/fec.c
> >>>@@ -1513,6 +1513,21 @@ static inline void fec_reset_phy(struct platform_device *pdev)
> >>>  }
> >>>  #endif /* CONFIG_OF */
> >>>
> >>>+/* For imx6q sabrelite board: set KSZ9021RN RGMII pad skew */
> >>>+static int ksz9021rn_phy_fixup(struct phy_device *phydev)
> >>>+{
> >>>+       /* min rx data delay */
> >>>+       phy_write(phydev, 0x0b, 0x8105);
> >>>+       phy_write(phydev, 0x0c, 0x0000);
> >>>+
> >>>+       /* max rx/tx clock delay, min rx/tx control delay */
> >>>+       phy_write(phydev, 0x0b, 0x8104);
> >>>+       phy_write(phydev, 0x0c, 0xf0f0);
> >>>+       phy_write(phydev, 0x0b, 0x104);
> >>>+
> >>>+       return 0;
> >>
> >>This should go to drivers/net/phy/micrel.c.
> >Why? It's specific to fec.
> 
> For me it seems to be a board specific and should be placed to the
> machine file. 
By converting to DT, machine code's becoming common too. I feel hard to
find a place. Put it in imx6q_init_machine?

Sascha & Shawn, Could you give comments here?

> Please include linux/micrel_phy.h and use proper
> defines (PHY_ID_KSZ9021, MICREL_PHY_ID_MASK).
right. thanks.

Richard
> 
> --
> Veli-Pekka Peltola
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html