Re: [PATCH FIX net v2] forcedeth: fix stats on hardware without extended stats support |
|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH FIX net v2] forcedeth: fix stats on hardware without extended stats support
- From: David Miller <davem@xxxxxxxxxxxxx>
- Date: Mon, 14 Nov 2011 00:15:14 -0500 (EST)
- Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, eric.dumazet@xxxxxxxxx, jeffrey.t.kirsher@xxxxxxxxx, jpirko@xxxxxxxxxx, joe@xxxxxxxxxxx, szymon@xxxxxxxxxxx, rick.jones2@xxxxxx, AAbdulla@xxxxxxxxxx
- In-reply-to: <51c23650f3fc6e48b652a7ab322ca09a1cb7cbcc.1321064621.git.david.decotigny@google.com>
From: David Decotigny <david.decotigny@xxxxxxxxxx>
Date: Fri, 11 Nov 2011 18:27:34 -0800
> This change makes sure that tx_packets/rx_bytes ifconfig counters are
> updated even on NICs that don't provide hardware support for these
> stats: they are now updated in software. For the sake of consistency,
> we also now have tx_bytes updated in software (hardware counters
> include ethernet CRC, and software doesn't account for it).
>
> This reverts parts of:
> - "forcedeth: statistics optimization" (21828163b2)
> - "forcedeth: Improve stats counters" (0bdfea8ba8)
> - "forcedeth: remove unneeded stats updates" (4687f3f364)
>
> Tested:
> pktgen + loopback (http://patchwork.ozlabs.org/patch/124698/)
> reports identical tx_packets/rx_packets and tx_bytes/rx_bytes.
>
> Signed-off-by: David Decotigny <david.decotigny@xxxxxxxxxx>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Kernel Discussion]
[Ethernet Bridging]
[Linux Wireless Networking]
[Linux Bluetooth Networking]
[Linux Networking Users]
[VLAN]
[Git]
[IETF Annouce]
[Linux Assembly]
[Security]
[Bugtraq]
[Photo]
[Singles Social Networking]
[Yosemite Information]
[MIPS Linux]
[ARM Linux Kernel]
[ARM Linux]
[Linux Virtualization]
[Linux Security]
[Linux IDE]
[Linux RAID]
[Linux SCSI]
[Free Dating]