Re: [PATCH 1/2] xfrm4: fix the ports decode of sctp protocol

[David Miller <davem@xxxxxxxxxxxxx>]

From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 3 Jul 2009 11:48:49 +0800

> On Fri, Jul 03, 2009 at 10:57:23AM +0800, Wei Yongjun wrote:
>> The SCTP pushed the skb data above the sctp chunk header, so the check
>> of pskb_may_pull(skb, xprth + 4 - skb->data) in _decode_session4() will
>> never return 0 because xprth + 4 - skb->data < 0, the ports decode of
>> sctp will always fail.
>> 
>> Signed-off-by: Wei Yongjun <yjwei@xxxxxxxxxxxxxx>
> 
> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Applied.

> Longer term I wonder if we can move this stuff into the protocol
> code, i.e., before they call xfrm_policy_check.

That ought to work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html